Add a reader for Meris L2 data #1678
Conversation
{dataset_name}_rho_w.nc
Codecov Report
@@ Coverage Diff @@
## main #1678 +/- ##
==========================================
+ Coverage 94.30% 94.32% +0.01%
==========================================
Files 306 308 +2
Lines 46043 46168 +125
==========================================
+ Hits 43421 43546 +125
Misses 2622 2622
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
introducing self.reflectance_prefix and self.reflectance_suffix to NCOLCIChannelBase
|
@JohannesSMHI Great start, nice that so much of the Olci reader can be reused! Now we are just waiting for the tests :) |
|
@mraspaud Goodie! Should I create the tests as well, or will someone else do that? |
|
I would say that you are probably the best person to do that :) |
More or less copied the code from test_olci_nc.py
|
|
||
| import numpy as np | ||
|
|
||
| from satpy.readers.olci_nc import ( |
There was a problem hiding this comment.
F401 'satpy.readers.olci_nc.NCOLCILowResData' imported but unused
There was a problem hiding this comment.
@mraspaud yep, that is solved.. but how about all the changes you did with the olci_l2. reader before the summer (eg. the BitFlags class) ? will the merge take care of that or do we need to adjust before we merge?
|
@mraspaud would you consider this PR to be "Fully documented" ? |
|
@JohannesSMHI This sadly seems to have some merge conflicts by now. Any chance of looking into those? |
|
@gerritholl, I´ll try to find time for this after my vaccation :) |
|
@johannesocean @gerritholl and @mraspaud |
adybbroe
added
enhancement
There was a problem hiding this comment.
LGTM! Thanks @johannesocean for the PR and @adybbroe for finalizing!
New reader for ENVISAT-MERIS data. The 4th generation reprocessing of MERIS data implements a Sentinel 3 like format including Level 2 products and TOA-radiances in the same dataset package. Hence, we can use the same reader as for the OLCI sensor. Basically we only add a yaml-file (meris_nc_sen3) and some minor changes to the OLCI-scripts
I will follow up with an extension of the TOA datasets in the upcoming weeks..