Fix SandwichCompositor modifying input data #1690
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In issue #1689 we realized that generating a true color composite while also generating a sandwich composite of that same true color produced an all black image. With this PR the SandwichCompositor no longer does an inplace operation.
One could argue that the utility methods used by the composites should always pass copies, but I think this is unnecessary in most cases and I'm scared it would hurt performance in the worst cases. This is the first time we've run into something like this...I think.