Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve various documentation issues #1697

Merged
merged 2 commits into from Jun 1, 2021

Conversation

@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #1697 (cf4d656) into main (25993ff) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1697   +/-   ##
=======================================
  Coverage   92.32%   92.32%           
=======================================
  Files         258      258           
  Lines       38125    38125           
=======================================
  Hits        35200    35200           
  Misses       2925     2925           
Flag Coverage Δ
behaviourtests 4.84% <ø> (ø)
unittests 92.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/resample.py 80.24% <ø> (ø)
satpy/writers/cf_writer.py 95.17% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25993ff...cf4d656. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.818% when pulling cf4d656 on BENR0:gh_documentation_issues into 25993ff on pytroll:main.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Looks good to me. The website CI job failed because of an HTTP timeout when creating the environment. I've restarted it. Once that passes I'm ok with this being merged.

@djhoese djhoese self-assigned this May 28, 2021
@djhoese djhoese merged commit 0a82ff0 into pytroll:main Jun 1, 2021
@djhoese djhoese changed the title Solves some Github issues regarding documentation Solve various documentation issues Jun 1, 2021
@BENR0 BENR0 deleted the gh_documentation_issues branch June 2, 2021 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants