Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SLSTR reader to choose correct file for interpolated angles #1706

Merged
merged 7 commits into from Jun 4, 2021

Conversation

simonrp84
Copy link
Member

@simonrp84 simonrp84 commented Jun 1, 2021

At present, the SLSTR reader does not choose the correct file for interpolated angle datasets. It needs the cartesian coordinate file and chooses in by default, which is the IR (1km) resolution file.
This PR allows the reader to select the an file, which is at VIS resolution of 500m pixel size when required. This will enable angles to be correctly interpolated onto the SLSTR grid.

This partially addresses #1702 but does not allow angles to be interpolated correctly onto the IR grid as (I think) the 500m lat/lon grid is always selected.

  • Tests added

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #1706 (72e0ac4) into main (25993ff) will increase coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1706      +/-   ##
==========================================
+ Coverage   92.32%   92.55%   +0.22%     
==========================================
  Files         258      258              
  Lines       38125    38298     +173     
==========================================
+ Hits        35200    35445     +245     
+ Misses       2925     2853      -72     
Flag Coverage Δ
behaviourtests 4.84% <0.00%> (-0.01%) ⬇️
unittests 93.09% <100.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/slstr_l1b.py 97.29% <100.00%> (+21.72%) ⬆️
satpy/tests/reader_tests/test_slstr_l1b.py 100.00% <100.00%> (ø)
satpy/tests/test_readers.py 98.86% <0.00%> (-0.37%) ⬇️
satpy/tests/reader_tests/test_nucaps.py 100.00% <0.00%> (ø)
satpy/tests/reader_tests/test_sar_c_safe.py 100.00% <0.00%> (ø)
satpy/readers/fci_l1c_fdhsi.py
satpy/tests/reader_tests/test_fci_l1c_fdhsi.py
satpy/readers/fci_l1c_nc.py 97.97% <0.00%> (ø)
satpy/tests/reader_tests/test_fci_l1c_nc.py 100.00% <0.00%> (ø)
satpy/tests/test_composites.py 99.88% <0.00%> (+<0.01%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25993ff...72e0ac4. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 1, 2021

Coverage Status

Coverage increased (+0.2%) to 93.039% when pulling 72e0ac4 on simonrp84:slstr into 25993ff on pytroll:main.

satpy/readers/slstr_l1b.py Outdated Show resolved Hide resolved
@simonrp84 simonrp84 requested a review from djhoese as a code owner June 2, 2021 20:43
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit fbcf859 into pytroll:main Jun 4, 2021
@simonrp84 simonrp84 deleted the slstr branch November 16, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants