Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Clavrx reader for netcdf files #1716

Merged
merged 17 commits into from Jun 15, 2021
Merged

Update Clavrx reader for netcdf files #1716

merged 17 commits into from Jun 15, 2021

Conversation

joleenf
Copy link
Contributor

@joleenf joleenf commented Jun 3, 2021

The PR updates the current CLAVRX HDF reader to include a netcdf reader for geostationary files currently being produced.

satpy/readers/clavrx.py Show resolved Hide resolved
satpy/readers/clavrx.py Outdated Show resolved Hide resolved
satpy/readers/clavrx.py Outdated Show resolved Hide resolved
satpy/readers/clavrx.py Show resolved Hide resolved
satpy/readers/clavrx.py Show resolved Hide resolved
satpy/readers/clavrx.py Show resolved Hide resolved
satpy/readers/clavrx.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #1716 (3a88cdd) into main (217c6e2) will increase coverage by 0.40%.
The diff coverage is 90.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1716      +/-   ##
==========================================
+ Coverage   92.43%   92.83%   +0.40%     
==========================================
  Files         258      260       +2     
  Lines       38273    38552     +279     
==========================================
+ Hits        35376    35791     +415     
+ Misses       2897     2761     -136     
Flag Coverage Δ
behaviourtests 4.81% <0.00%> (-0.04%) ⬇️
unittests 93.38% <90.69%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/clavrx.py 89.37% <86.53%> (-3.32%) ⬇️
satpy/tests/reader_tests/test_clavrx.py 100.00% <100.00%> (ø)
satpy/tests/reader_tests/test_clavrx_nc.py 100.00% <100.00%> (ø)
satpy/resample.py 80.24% <0.00%> (ø)
satpy/tests/test_dataset.py 100.00% <0.00%> (ø)
satpy/tests/reader_tests/test_nucaps.py 100.00% <0.00%> (ø)
satpy/tests/reader_tests/test_abi_l2_nc.py 100.00% <0.00%> (ø)
satpy/tests/reader_tests/test_slstr_l1b.py 100.00% <0.00%> (ø)
satpy/readers/fci_l1c_fdhsi.py
satpy/tests/reader_tests/test_fci_l1c_fdhsi.py
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 217c6e2...3a88cdd. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 3, 2021

Coverage Status

Coverage increased (+0.4%) to 93.325% when pulling 3a88cdd on joleenf:clavrx into 1289aa3 on pytroll:main.

@joleenf
Copy link
Contributor Author

joleenf commented Jun 9, 2021

The PR updates the current CLAVRX HDF reader to include a netcdf reader for geostationary files currently being produced.

Closes #1661
Tests for netcdf reader have been added.

@joleenf joleenf marked this pull request as ready for review June 9, 2021 12:35
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small changes, otherwise this looks pretty good to me. You mentioned you were worried about using the utilities classes correctly. Was there something specific you wanted me to look at?

satpy/readers/clavrx.py Outdated Show resolved Hide resolved
satpy/readers/clavrx.py Outdated Show resolved Hide resolved
satpy/readers/clavrx.py Show resolved Hide resolved
satpy/tests/reader_tests/test_clavrx_nc.py Outdated Show resolved Hide resolved
Update copyright
Move code into _CLAVRxHelper that handles data reading and scaling
@djhoese djhoese added component:readers enhancement code enhancements, features, improvements labels Jun 15, 2021
@djhoese djhoese self-assigned this Jun 15, 2021
@djhoese djhoese merged commit 7b8eb8d into pytroll:main Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for clavrx netcdf files
4 participants