Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add low resolution file patterns for AHI HSD reader #1717

Merged

Conversation

mherbertson
Copy link
Contributor

This PR adds ability to read low resolution AHI HSD file format created by a sample JMA utility. As this utility requires the .DAT file, a bz2 format shouldn't be required.

https://www.data.jma.go.jp/mscweb/en/himawari89/space_segment/spsg_sample.html

@mherbertson mherbertson changed the title Add low resolution file patterns Add low resolution file patterns for AHI HSD reader Jun 4, 2021
@djhoese djhoese added component:readers enhancement code enhancements, features, improvements labels Jun 4, 2021
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works for you then I am 👍 with it.

@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #1717 (648f76a) into main (1289aa3) will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1717      +/-   ##
==========================================
+ Coverage   92.44%   92.55%   +0.10%     
==========================================
  Files         258      258              
  Lines       38279    38298      +19     
==========================================
+ Hits        35388    35445      +57     
+ Misses       2891     2853      -38     
Flag Coverage Δ
behaviourtests 4.84% <ø> (-0.01%) ⬇️
unittests 93.09% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/tests/reader_tests/test_slstr_l1b.py 100.00% <0.00%> (ø)
satpy/readers/slstr_l1b.py 97.29% <0.00%> (+21.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1289aa3...648f76a. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 4, 2021

Coverage Status

Coverage increased (+0.1%) to 93.039% when pulling 648f76a on mherbertson:feature-ahi-reader-add-extra-format into 1289aa3 on pytroll:main.

@mraspaud
Copy link
Member

mraspaud commented Jun 4, 2021

Don't forget to add you name to AUTHORS.md!

@djhoese
Copy link
Member

djhoese commented Jun 7, 2021

This looks good to me. I'm going to wait for @mraspaud to decide if we merge this now and release it as part of 0.29.1 or wait for that release and include this as a "feature" in 0.30.0.

@mraspaud mraspaud merged commit e62eb9d into pytroll:main Jun 7, 2021
@mherbertson mherbertson deleted the feature-ahi-reader-add-extra-format branch June 7, 2021 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants