Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test to ensure seviri hrv has priority over vis008 when requesting 0.8µm #1720

Merged
merged 1 commit into from Jun 10, 2021

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Jun 9, 2021

This PR just adds a test to settle an unclear behaviour.

  • Tests added
  • Fully documented

@mraspaud mraspaud added enhancement code enhancements, features, improvements component:tests labels Jun 9, 2021
@mraspaud mraspaud self-assigned this Jun 9, 2021
@mraspaud mraspaud requested a review from djhoese as a code owner June 9, 2021 11:38
@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #1720 (351e2c8) into main (cf546ba) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1720      +/-   ##
==========================================
+ Coverage   92.56%   92.58%   +0.02%     
==========================================
  Files         258      258              
  Lines       38338    38343       +5     
==========================================
+ Hits        35487    35501      +14     
+ Misses       2851     2842       -9     
Flag Coverage Δ
behaviourtests 4.83% <0.00%> (+<0.01%) ⬆️
unittests 93.13% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/tests/test_dataset.py 100.00% <100.00%> (ø)
satpy/dataset/dataid.py 94.27% <0.00%> (+0.22%) ⬆️
satpy/tests/reader_tests/test_vii_base_nc.py 98.78% <0.00%> (+1.21%) ⬆️
satpy/tests/reader_tests/test_nwcsaf_msg.py 98.31% <0.00%> (+1.68%) ⬆️
satpy/tests/reader_tests/test_vii_l1b_nc.py 100.00% <0.00%> (+2.81%) ⬆️
satpy/tests/reader_tests/test_vii_l2_nc.py 100.00% <0.00%> (+6.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf546ba...351e2c8. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 93.076% when pulling 351e2c8 on mraspaud:fix-seviri-vis008-vs-hrv into cf546ba on pytroll:main.

@mraspaud
Copy link
Member Author

@djhoese any comment on this?

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused. Based on the slack conversation don't we want 0.8 to give VIS008 back? Or is the current behavior actually desired?

@mraspaud
Copy link
Member Author

I think the approach is consistent, in that higher resolution is said to be preferred. I was confused earlier because the previous behaviour preferred nearer center wavelength.

But in the end, I think I agree with #1721 , but for now this is good enough.

@djhoese djhoese merged commit f7afc2e into pytroll:main Jun 10, 2021
@mraspaud mraspaud deleted the fix-seviri-vis008-vs-hrv branch June 11, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:tests enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants