Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for MultiScene.blend #1751

Merged
merged 3 commits into from Aug 19, 2021

Conversation

gerritholl
Copy link
Collaborator

In the MultiScene.blend docstring, explain what it actually does and
what the interface of the blend function should be.

In the `MultiScene.blend` docstring, explain what it actually does and
what the interface of the blend function should be.
@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #1751 (33780f4) into main (b2af59a) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1751      +/-   ##
==========================================
- Coverage   92.83%   92.83%   -0.01%     
==========================================
  Files         260      260              
  Lines       38556    38558       +2     
==========================================
+ Hits        35793    35794       +1     
- Misses       2763     2764       +1     
Flag Coverage Δ
behaviourtests 4.81% <ø> (-0.01%) ⬇️
unittests 93.37% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/multiscene.py 91.10% <ø> (ø)
satpy/readers/virr_l1b.py 94.59% <0.00%> (-1.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2af59a...33780f4. Read the comment docs.

@coveralls
Copy link

coveralls commented Jul 2, 2021

Coverage Status

Coverage remained the same at 93.319% when pulling 33780f4 on gerritholl:improve-blend-docs into f736315 on pytroll:main.

@gerritholl
Copy link
Collaborator Author

If #1752 is merged first, I'll add a commit here to document what's new in #1752.

@gerritholl gerritholl mentioned this pull request Jul 2, 2021
3 tasks
satpy/multiscene.py Outdated Show resolved Hide resolved
gerritholl and others added 2 commits July 2, 2021 17:41
Fix typos as detected by @djhoese

Co-authored-by: David Hoese <david.hoese@ssec.wisc.edu>
@gerritholl
Copy link
Collaborator Author

Can't we also check the RTD website via CI / build website or so?

@djhoese
Copy link
Member

djhoese commented Jul 2, 2021

Well it looks like it doesn't pass right now, but I think if we wanted to do that (link to it and view it) we'd have to do something with artifacts. I'm not sure how that would work and I haven't tried. Could be fun for a PCW/sprint some time.

@djhoese
Copy link
Member

djhoese commented Jul 2, 2021

We could use this: https://github.com/actions/upload-artifact but then we'd have to download the output. Might just be easier to trust that it is going to render properly locally. Also, I think we can opt-in to having readthedocs work on pull requests.

@gerritholl
Copy link
Collaborator Author

Why is the build website not passing? It looks like it fails already in building up the conda environment? Is this related to my PR?

@djhoese
Copy link
Member

djhoese commented Jul 5, 2021

No, it was a download/connection issue. Restarted now.

@djhoese djhoese self-assigned this Aug 19, 2021
@djhoese djhoese merged commit 9526d31 into pytroll:main Aug 19, 2021
@gerritholl gerritholl deleted the improve-blend-docs branch August 26, 2021 15:16
simonrp84 pushed a commit to simonrp84/satpy that referenced this pull request Nov 24, 2021
* Improve documentation for MultiScene.blend

In the `MultiScene.blend` docstring, explain what it actually does and
what the interface of the blend function should be.

* Update satpy/multiscene.py

Fix typos as detected by @djhoese

Co-authored-by: David Hoese <david.hoese@ssec.wisc.edu>

* Fix sphinx links

Co-authored-by: David Hoese <david.hoese@ssec.wisc.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiScene.blend does not document the interface for the blend function
3 participants