Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks for seviri hrit #1760

Merged
merged 18 commits into from
Jul 23, 2021
Merged

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Jul 14, 2021

This PR adds download/demo methods for SEVIRI data in HRIT format and some benchmarks

  • Tests added
  • Fully documented

@mraspaud mraspaud added enhancement code enhancements, features, improvements component:tests labels Jul 14, 2021
@mraspaud mraspaud self-assigned this Jul 14, 2021
@ghost
Copy link

ghost commented Jul 14, 2021

Congratulations 🎉. DeepCode analyzed your code in 3.669 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

👉 The DeepCode service and API will be deprecated in August, 2021. Here is the information how to migrate. Thank you for using DeepCode 🙏 ❤️ !

If you are using our plugins, you might be interested in their successors: Snyk's JetBrains plugin and Snyk's VS Code plugin.

@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #1760 (54bd52e) into main (4d34625) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1760      +/-   ##
==========================================
+ Coverage   92.82%   92.87%   +0.04%     
==========================================
  Files         263      265       +2     
  Lines       38717    38853     +136     
==========================================
+ Hits        35940    36084     +144     
+ Misses       2777     2769       -8     
Flag Coverage Δ
behaviourtests 4.78% <0.00%> (-0.02%) ⬇️
unittests 93.41% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/demo/__init__.py 100.00% <100.00%> (ø)
satpy/demo/ahi_hsd.py 95.83% <100.00%> (ø)
satpy/demo/seviri_hrit.py 100.00% <100.00%> (ø)
satpy/demo/utils.py 100.00% <100.00%> (ø)
satpy/demo/viirs_sdr.py 100.00% <100.00%> (ø)
satpy/tests/test_demo.py 99.29% <100.00%> (+0.33%) ⬆️
satpy/tests/reader_tests/test_vii_base_nc.py 98.78% <0.00%> (+1.21%) ⬆️
satpy/tests/reader_tests/test_nwcsaf_msg.py 98.31% <0.00%> (+1.68%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d34625...54bd52e. Read the comment docs.

@coveralls
Copy link

coveralls commented Jul 22, 2021

Coverage Status

Coverage remained the same at 93.357% when pulling 54bd52e on mraspaud:feature-hrit-benchmarks into 4d34625 on pytroll:main.

@mraspaud mraspaud marked this pull request as ready for review July 22, 2021 09:07
@mraspaud mraspaud requested a review from djhoese as a code owner July 22, 2021 09:07
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One clean code suggestion, one confusion with possibly broken code, but otherwise I'm guessing this filesystem stuff in the tests avoids touching disk completely? Is this something the VIIRS SDR tests could be updated with?

satpy/demo/seviri_hrit.py Outdated Show resolved Hide resolved
benchmarks/ahi_hsd_benchmarks.py Show resolved Hide resolved
@mraspaud
Copy link
Member Author

I'm running the benchmarks now locally, but I think this is ready

@mraspaud
Copy link
Member Author

As for the filesystem stuff, maybe it could work for viirs, I can give it a try.

They now use the mock_filesystem, and do actual checks on the number of downloads.
@mraspaud
Copy link
Member Author

I'm merging this to have time to run all the benchmarks today on EWC

@mraspaud mraspaud merged commit 07a87af into pytroll:main Jul 23, 2021
@mraspaud mraspaud deleted the feature-hrit-benchmarks branch July 23, 2021 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:tests enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants