-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmarks for seviri hrit #1760
Conversation
👉 View analysis in DeepCode’s Dashboard | Configure the bot👉 The DeepCode service and API will be deprecated in August, 2021. Here is the information how to migrate. Thank you for using DeepCode 🙏 ❤️ !If you are using our plugins, you might be interested in their successors: Snyk's JetBrains plugin and Snyk's VS Code plugin. |
Codecov Report
@@ Coverage Diff @@
## main #1760 +/- ##
==========================================
+ Coverage 92.82% 92.87% +0.04%
==========================================
Files 263 265 +2
Lines 38717 38853 +136
==========================================
+ Hits 35940 36084 +144
+ Misses 2777 2769 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One clean code suggestion, one confusion with possibly broken code, but otherwise I'm guessing this filesystem stuff in the tests avoids touching disk completely? Is this something the VIIRS SDR tests could be updated with?
I'm running the benchmarks now locally, but I think this is ready |
As for the filesystem stuff, maybe it could work for viirs, I can give it a try. |
They now use the mock_filesystem, and do actual checks on the number of downloads.
I'm merging this to have time to run all the benchmarks today on EWC |
This PR adds download/demo methods for SEVIRI data in HRIT format and some benchmarks