Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing demo data directory entry to config documentation #1765

Merged
merged 1 commit into from Aug 18, 2021

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Jul 16, 2021

This was brought up by @gerritholl on slack. This specifies the default value of '.' and documents it including a linking to the demo data module.

  • Closes #xxxx
  • Tests added
  • Fully documented

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #1765 (ae97c0e) into main (4d34625) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1765      +/-   ##
==========================================
+ Coverage   92.82%   92.84%   +0.02%     
==========================================
  Files         263      263              
  Lines       38717    38717              
==========================================
+ Hits        35940    35948       +8     
+ Misses       2777     2769       -8     
Flag Coverage Δ
behaviourtests 4.80% <ø> (+<0.01%) ⬆️
unittests 93.38% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/_config.py 98.59% <ø> (ø)
satpy/tests/reader_tests/test_vii_base_nc.py 98.78% <0.00%> (+1.21%) ⬆️
satpy/tests/reader_tests/test_nwcsaf_msg.py 98.31% <0.00%> (+1.68%) ⬆️
satpy/tests/reader_tests/test_vii_l1b_nc.py 100.00% <0.00%> (+2.81%) ⬆️
satpy/tests/reader_tests/test_vii_l2_nc.py 100.00% <0.00%> (+6.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d34625...ae97c0e. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.333% when pulling ae97c0e on djhoese:bugfix-config-demo-data-dir into 4d34625 on pytroll:main.

@djhoese djhoese merged commit 3b771a8 into pytroll:main Aug 18, 2021
@djhoese djhoese deleted the bugfix-config-demo-data-dir branch August 18, 2021 18:41
simonrp84 pushed a commit to simonrp84/satpy that referenced this pull request Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants