Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ABI readers not assigning 'platform_name' for GOES-18/19 #1784

Merged
merged 2 commits into from Aug 5, 2021

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Aug 5, 2021

Simple fix so that the ABI-based readers know about GOES-18/19. This came up in SIFT development where the data and most of the metadata was perfectly fine, but platform_name was missing (was set to None).

  • Closes #xxxx
  • Tests added
  • Fully documented

@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #1784 (007cf02) into main (983961b) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1784   +/-   ##
=======================================
  Coverage   92.90%   92.90%           
=======================================
  Files         265      265           
  Lines       38970    38970           
=======================================
  Hits        36205    36205           
  Misses       2765     2765           
Flag Coverage Δ
behaviourtests 4.77% <0.00%> (ø)
unittests 93.44% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/abi_base.py 94.59% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 983961b...007cf02. Read the comment docs.

@coveralls
Copy link

coveralls commented Aug 5, 2021

Coverage Status

Coverage remained the same at 93.387% when pulling 007cf02 on djhoese:bugfix-abi-g18 into 983961b on pytroll:main.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mraspaud mraspaud merged commit 4c7c94b into pytroll:main Aug 5, 2021
@djhoese djhoese deleted the bugfix-abi-g18 branch August 6, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants