Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ABI L1B benchmarks #1790

Merged
merged 1 commit into from Aug 13, 2021
Merged

Conversation

mraspaud
Copy link
Member

This PR adds benchmarks for the abi l1b reader

@mraspaud mraspaud added the enhancement code enhancements, features, improvements label Aug 13, 2021
@mraspaud mraspaud self-assigned this Aug 13, 2021
@mraspaud mraspaud requested a review from djhoese as a code owner August 13, 2021 09:50
@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #1790 (d96f90c) into main (4c7c94b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1790   +/-   ##
=======================================
  Coverage   92.90%   92.90%           
=======================================
  Files         265      265           
  Lines       38970    38970           
=======================================
  Hits        36205    36205           
  Misses       2765     2765           
Flag Coverage Δ
behaviourtests 4.77% <ø> (ø)
unittests 93.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c7c94b...d96f90c. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.387% when pulling d96f90c on mraspaud:feature-abi-benchmarks into 4c7c94b on pytroll:main.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming these all still run then 👍

@mraspaud
Copy link
Member Author

Just tried locally and it looks fine

@mraspaud mraspaud merged commit 7c27fa4 into pytroll:main Aug 13, 2021
@mraspaud mraspaud deleted the feature-abi-benchmarks branch August 13, 2021 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants