Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning in 'awips_tiled' writer when 'units' are too long #1802

Merged
merged 2 commits into from Aug 25, 2021

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Aug 24, 2021

AWIPS has nice random limits to attributes depending on where and how it puts it in a database. Apparently the units attribute is limited to 26 characters. This PR adds a warning and forces the units to 26 characters.

CC @deeplycloudy @nbearson

@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #1802 (f473616) into main (9526d31) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1802      +/-   ##
==========================================
+ Coverage   92.91%   92.93%   +0.02%     
==========================================
  Files         265      265              
  Lines       39012    39112     +100     
==========================================
+ Hits        36247    36348     +101     
+ Misses       2765     2764       -1     
Flag Coverage Δ
behaviourtests 4.75% <0.00%> (-0.02%) ⬇️
unittests 93.46% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/tests/writer_tests/test_awips_tiled.py 98.48% <100.00%> (+0.06%) ⬆️
satpy/writers/awips_tiled.py 82.86% <100.00%> (+0.11%) ⬆️
satpy/tests/reader_tests/test_abi_l1b.py 99.25% <0.00%> (-0.75%) ⬇️
satpy/readers/netcdf_utils.py 100.00% <0.00%> (ø)
satpy/tests/reader_tests/test_hy2_scat_l2b_h5.py 100.00% <0.00%> (ø)
satpy/tests/reader_tests/test_netcdf_utils.py 94.89% <0.00%> (+0.10%) ⬆️
satpy/readers/hy2_scat_l2b_h5.py 98.21% <0.00%> (+0.21%) ⬆️
satpy/readers/abi_l1b.py 98.61% <0.00%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9526d31...f473616. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 93.414% when pulling f473616 on djhoese:bugfix-awips-tiled-long-units into 2a81e65 on pytroll:main.

@djhoese djhoese merged commit 17cbfe0 into pytroll:main Aug 25, 2021
@djhoese djhoese deleted the bugfix-awips-tiled-long-units branch August 25, 2021 15:57
simonrp84 pushed a commit to simonrp84/satpy that referenced this pull request Nov 24, 2021
…l#1802)

* Add warning in 'awips_tiled' writer when 'units' are too long

* Fix warning message contains checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants