New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'day_night' flag to DayNightCompositor for day-only or night-only results #1816
Merged
Merged
Changes from 29 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
9cce883
Update __init__.py
yukaribbba 4a75db1
Update __init__.py
yukaribbba b3b7b35
Update __init__.py
yukaribbba 2ceb218
Update __init__.py
yukaribbba 80ed09a
Merge branch 'main' into feature-daynightcompositor
djhoese 630baaf
tests
yukaribbba b294981
Revert "tests"
yukaribbba baf8501
Revert "Merge branch 'main' into feature-daynightcompositor"
yukaribbba 6bcf7eb
Revert "Revert "Merge branch 'main' into feature-daynightcompositor""
yukaribbba 82b84a6
update add_bands_test
yukaribbba a700799
update DayNightCompositor test
yukaribbba 9bf4207
update DayNightCompositor test
yukaribbba ca5c3e9
new structure
yukaribbba f5c873b
Update __init__.py
yukaribbba 73c2cdc
Update __init__.py
yukaribbba 142e4a5
Update __init__.py
yukaribbba 8d58657
Update __init__.py
yukaribbba 926389e
Update __init__.py
yukaribbba 70f43ee
Update __init__.py
yukaribbba 360d876
Update test_composites.py
yukaribbba 0f23b88
Update satpy/composites/__init__.py
yukaribbba 1b14f7f
Update satpy/composites/__init__.py
djhoese a571014
Update __init__.py
yukaribbba 4c00823
Update __init__.py
yukaribbba 5c265b2
Update __init__.py
yukaribbba 4f32c4c
Update __init__.py
yukaribbba 8cdc9fa
Update __init__.py
yukaribbba cd55547
Update __init__.py
yukaribbba 8d8377a
Update __init__.py
yukaribbba af2c6ee
Update __init__.py
yukaribbba 787a6a9
Merge remote-tracking branch 'upstream/main' into feature-daynightcom…
yukaribbba 0a75d4a
Update __init__.py
yukaribbba b59557f
Update composites.rst
yukaribbba 9922f23
Update AUTHORS.md
yukaribbba 872d95a
Update doc/source/composites.rst
djhoese File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
match_data_arrays
should always be called. You can doprojectables = self.match_data_arrays(projectables)
just above this line.match_data_arrays
checks a lot of various things and modifies the provided DataArrays as needed to make them compatible with the compositor or with the rest of Satpy.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well when I tested
true_color_with_night_ir_alpha
I got errors sayingDimension 'bands' size mismatch: 3 != 4
withmatch_data_arrays
. This even occurred under original version. I didn't know what happened...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something related with #1821 and #1813 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is exactly #1821. I'm trying to finish #1815 and then fix #1821. Everything is just taking longer than I expected. One work around is to switch to an older version of xarray (
<0.19.0
if I remember correctly).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok so I'll just put
match_data_arrays
back here.