Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ninjotiff writer for mode P #1817

Merged
merged 1 commit into from Sep 9, 2021
Merged

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Sep 3, 2021

This PR ensures that images with mode P are in uint8 dtype when sent to pyninjotiff

  • Tests added

@mraspaud mraspaud added enhancement code enhancements, features, improvements component:writers labels Sep 3, 2021
@mraspaud mraspaud self-assigned this Sep 3, 2021
@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #1817 (75ddb77) into main (4c475fa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1817   +/-   ##
=======================================
  Coverage   93.05%   93.05%           
=======================================
  Files         266      266           
  Lines       39243    39257   +14     
=======================================
+ Hits        36517    36531   +14     
  Misses       2726     2726           
Flag Coverage Δ
behaviourtests 4.74% <0.00%> (-0.01%) ⬇️
unittests 93.59% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/tests/writer_tests/test_ninjotiff.py 100.00% <100.00%> (ø)
satpy/writers/ninjotiff.py 79.66% <100.00%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c475fa...75ddb77. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 93.535% when pulling 75ddb77 on mraspaud:fix-ninjo-p into 4c475fa on pytroll:main.

@mraspaud mraspaud merged commit a8496c8 into pytroll:main Sep 9, 2021
@mraspaud mraspaud deleted the fix-ninjo-p branch September 9, 2021 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:writers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants