Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional ACSPO reader file patterns #1824

Merged
merged 1 commit into from Sep 17, 2021

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Sep 16, 2021

New versions of the ACSPO files can have new filenames where "SSTskin" was replaced with "SSTsubskin". This PR also changes the unittest-based test class to a pytest one so that I could do parametrize tests.

  • Tests added

@djhoese djhoese added enhancement code enhancements, features, improvements component:readers labels Sep 16, 2021
@djhoese djhoese self-assigned this Sep 16, 2021
@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #1824 (4d2b1e5) into main (bc23a0d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1824   +/-   ##
=======================================
  Coverage   93.02%   93.02%           
=======================================
  Files         268      268           
  Lines       39576    39577    +1     
=======================================
+ Hits        36816    36817    +1     
  Misses       2760     2760           
Flag Coverage Δ
behaviourtests 4.72% <0.00%> (-0.01%) ⬇️
unittests 93.60% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/tests/reader_tests/test_acspo.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc23a0d...4d2b1e5. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0002%) to 93.542% when pulling 4d2b1e5 on djhoese:feature-new-acspo-names into bc23a0d on pytroll:main.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 0c66281 into pytroll:main Sep 17, 2021
@djhoese djhoese deleted the feature-new-acspo-names branch September 17, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants