Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eumetsat urls in satpy/readers #1827

Merged
merged 1 commit into from Sep 22, 2021
Merged

Conversation

pdebuyl
Copy link
Contributor

@pdebuyl pdebuyl commented Sep 20, 2021

I "grepped" for eumetsat.int in satpy/readers and fixed the ones returning an error 404.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR! always good to keep the documentation and the links up to date :)

@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #1827 (8cdf26b) into main (a6f26f3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1827   +/-   ##
=======================================
  Coverage   93.03%   93.03%           
=======================================
  Files         268      268           
  Lines       39625    39625           
=======================================
  Hits        36865    36865           
  Misses       2760     2760           
Flag Coverage Δ
behaviourtests 4.72% <ø> (ø)
unittests 93.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/mviri_l1b_fiduceo_nc.py 100.00% <ø> (ø)
satpy/readers/slstr_l1b.py 97.29% <ø> (ø)
satpy/readers/vii_l1b_nc.py 96.15% <ø> (ø)
satpy/readers/viirs_compact.py 76.04% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f26f3...8cdf26b. Read the comment docs.

@mraspaud
Copy link
Member

@pdebuyl I'm waiting for the ci action to work again to merge this. Nothing we can do about it right now, except to wait for coveralls to fix its database as mentionned on our slack :)

@pdebuyl
Copy link
Contributor Author

pdebuyl commented Sep 21, 2021

ok, thanks for the notice :-)

Copy link
Member

@sfinkens sfinkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@ameraner
Copy link
Member

Thank you for taking care of this!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.55% when pulling 8cdf26b on pdebuyl:fix_eumetsat_urls into a6f26f3 on pytroll:main.

@mraspaud mraspaud merged commit 7be15e4 into pytroll:main Sep 22, 2021
@mraspaud mraspaud changed the title fix eumetsat urls in satpy/readers Fix eumetsat urls in satpy/readers Sep 22, 2021
@pdebuyl pdebuyl deleted the fix_eumetsat_urls branch February 15, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken links to new EUMETSAT website
5 participants