Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing nodata tiff tag #186

Merged
merged 1 commit into from Feb 8, 2018
Merged

Add missing nodata tiff tag #186

merged 1 commit into from Feb 8, 2018

Conversation

memamm
Copy link

@memamm memamm commented Feb 8, 2018

Adding missing nodata tiff tag in geotiff.py if fill_value is not None as already exists in mpop (see corresponding commit)

  • Tests added
  • Tests passed
  • Passes git diff origin/develop **/*py | flake8 --diff
  • Fully documented

@djhoese djhoese self-assigned this Feb 8, 2018
@djhoese djhoese added the enhancement code enhancements, features, improvements label Feb 8, 2018
@djhoese
Copy link
Member

djhoese commented Feb 8, 2018

Awesome, will merge once tests pass.

@coveralls
Copy link

coveralls commented Feb 8, 2018 •
edited

Coverage Status

Coverage decreased (-0.009%) to 57.746% when pulling 0fb6200 on memamm:fix_add_nodata_tifftag into 1471e6c on pytroll:develop.

@djhoese djhoese merged commit 4823a3a into pytroll:develop Feb 8, 2018
@memamm
Copy link
Author

memamm commented Feb 8, 2018

Wow, that was fast, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@djhoese djhoese

Labels
enhancement code enhancements, features, improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@memamm @djhoese @coveralls