New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AHI HSD calibration coefficients #1908
Conversation
… than the default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing, otherwise lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, makes sense to use the latest coefficients! Can you please also update in the docs that this is the new default?
Regarding radiance clipping: Although I agree that clipping should at least be optional, maybe we should wait for a decision in #1911?
Codecov Report
@@ Coverage Diff @@
## main #1908 +/- ##
==========================================
- Coverage 93.41% 93.41% -0.01%
==========================================
Files 275 275
Lines 40732 40730 -2
==========================================
- Hits 38048 38046 -2
Misses 2684 2684
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
… default rather than nominal.
Ok, it seems that the tests are complaining about coverage in an unaffected file. Odd. Anyway, AHI coverage remains the same. Thanks for the pointer about documentation @sfinkens - I've updated the docs now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Currently, the AHI HSD reader uses the default calibration coefficients for VIS channels:
gain_count2rad_conversion
andoffset_count2rad_conversion
in Block 5 of the header.However, updated calibration coefficients are available in Block 6 of the header:
cali_gain_count2rad_conversion
andcali_offset_count2rad_conversion
.This PR switches from using the old coefficients by default to using the new ones by default.
In addition, this PR removes the clipping of negative radiances. In the current
main
branch any radiances below zero are automatically set to zero. This is undesirable as negative radiances are useful for analysing sensor noise, amongst other things, so I remove this unnecessary clipping.There is also clipping for the reflectance values, but I've left that in for further discussion.