Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Frequency range #1912

Merged
merged 1 commit into from Dec 8, 2021
Merged

Add Frequency range #1912

merged 1 commit into from Dec 8, 2021

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Dec 1, 2021

Adding the frequency range type for dataid

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@mraspaud mraspaud added the enhancement code enhancements, features, improvements label Dec 1, 2021
@mraspaud mraspaud self-assigned this Dec 1, 2021
@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #1912 (d183d87) into main (85656a8) will decrease coverage by 0.06%.
The diff coverage is 55.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1912      +/-   ##
==========================================
- Coverage   93.41%   93.34%   -0.07%     
==========================================
  Files         275      275              
  Lines       40732    40795      +63     
==========================================
+ Hits        38048    38082      +34     
- Misses       2684     2713      +29     
Flag Coverage Δ
behaviourtests 4.85% <26.15%> (+0.03%) ⬆️
unittests 93.91% <55.38%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/dataset/dataid.py 89.69% <44.23%> (-5.48%) ⬇️
satpy/readers/yaml_reader.py 96.55% <100.00%> (+<0.01%) ⬆️
satpy/tests/test_yaml_reader.py 99.55% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85656a8...d183d87. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 93.843% when pulling d183d87 on mraspaud:feature-mhs into 85656a8 on pytroll:main.

@mraspaud mraspaud added this to In progress in PCW Autumn 2021 via automation Dec 1, 2021
Copy link
Contributor

@adybbroe adybbroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine for me. I took it into the PR #1370 with the MHS-AAPP reader and tested, and so far it looks fine, it works as expected.

@adybbroe adybbroe merged commit f3d80b8 into pytroll:main Dec 8, 2021
PCW Autumn 2021 automation moved this from In progress to Done Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement code enhancements, features, improvements
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants