New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix geo interpolation for aapp data #1918
Conversation
This is actual data from hrpt_metop03_20211129_0631_15888.l1b
Codecov Report
@@ Coverage Diff @@
## main #1918 +/- ##
==========================================
+ Coverage 93.41% 93.52% +0.11%
==========================================
Files 275 277 +2
Lines 40731 41218 +487
==========================================
+ Hits 38047 38548 +501
+ Misses 2684 2670 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@ninahakansson Great work. Can you please describe what your PR does and why, in addition from adding more tests? The current description doesn't match the title |
@ninahakansson In your local satpy fork do: To fix for isort now you can do:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reporting and fixing this! I think we can just drop the regular interpolator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Switched to use the GeoInterpolator to interpolate the latitudes and longitudes for aapp data.
This gives correct results also near longitude 180 degrees but it is slower.
Added a test that show that interpolation of longitudes fails near longitude 180 degrees for aapp data
before the Interpolator was updated. Test data from file hrpt_metop03_20211129_0631_15888.l1b.
Before fix: