Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ABI cloud_phase composite recipe and enhancement #1922

Merged
merged 1 commit into from Dec 8, 2021

Conversation

yufeizhu600
Copy link
Contributor

@yufeizhu600 yufeizhu600 commented Dec 6, 2021

The current Eumetsat cloud phase composite in the abi.yaml config file seems not correct according to the recipe found on the Eumetsat website.
eum_cloud_phase
Also the link to the reference documentation in the cloud phase composite description is dead.
This PR has fixed the recipe in the enhancement and composite config files. Below is a sample of the cloud phase composite.
cloud_phase_2021340175021-1
For the interpretation of the colours in the image, please refer to this Cloud Phase RGB Quick Guide

For comparison, here is a sample from the current implementation of the cloud phase composite recipe.
cloud_phase_nogood

@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #1922 (510644f) into main (85656a8) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1922   +/-   ##
=======================================
  Coverage   93.41%   93.41%           
=======================================
  Files         275      275           
  Lines       40732    40738    +6     
=======================================
+ Hits        38048    38054    +6     
  Misses       2684     2684           
Flag Coverage Δ
behaviourtests 4.83% <ø> (+0.01%) ⬆️
unittests 93.95% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/tests/reader_tests/test_vii_l2_nc.py 93.93% <0.00%> (-6.07%) ⬇️
satpy/tests/reader_tests/test_vii_l1b_nc.py 97.18% <0.00%> (-2.82%) ⬇️
satpy/tests/reader_tests/test_nwcsaf_msg.py 96.63% <0.00%> (-1.69%) ⬇️
satpy/tests/reader_tests/test_vii_base_nc.py 98.75% <0.00%> (-1.25%) ⬇️
satpy/tests/test_config.py 93.84% <0.00%> (-0.77%) ⬇️
satpy/resample.py 79.34% <0.00%> (-0.69%) ⬇️
satpy/modifiers/geometry.py 87.30% <0.00%> (-0.20%) ⬇️
satpy/modifiers/angles.py 96.64% <0.00%> (-0.07%) ⬇️
satpy/readers/ahi_hsd.py 97.25% <0.00%> (-0.05%) ⬇️
satpy/readers/fci_l1c_nc.py 97.93% <0.00%> (-0.05%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85656a8...510644f. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.901% when pulling 510644f on yufeizhu600:eum_cloud_phase_composite into 008b06d on pytroll:main.

@djhoese djhoese added the bug label Dec 7, 2021
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, nice catch. Looks like the enhancement was never added at all. This looks good to me. The codebeat issues seem to be unrelated and probably due to you starting from an old main branch. I'll give others a chance to review this too, but otherwise I can merge this tomorrow if no one has anything else to say (remind me to merge this on slack if I forget).

@djhoese djhoese changed the title fix abi cloud_phase composite recipe Fix ABI cloud_phase composite recipe and enhancement Dec 8, 2021
@djhoese djhoese merged commit a430f86 into pytroll:main Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants