Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ABI-specific configs for Airmass composite #195

Merged
merged 5 commits into from Feb 21, 2018
Merged

Add ABI-specific configs for Airmass composite #195

merged 5 commits into from Feb 21, 2018

Conversation

goodsonr
Copy link
Contributor

@goodsonr goodsonr commented Feb 16, 2018 •
edited by djhoese

Add ABI specific configs for Airmass composite

  • Tests added

  • Tests passed

  • Fully documented

@coveralls
Copy link

coveralls commented Feb 16, 2018 •
edited

Coverage Status

Coverage remained the same at 57.755% when pulling 4c5a812 on goodsonr:config-abi-airmass into 37644b1 on pytroll:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.755% when pulling 4c5a812 on goodsonr:config-abi-airmass into 37644b1 on pytroll:develop.

@coveralls
Copy link

coveralls commented Feb 16, 2018 •
edited

Coverage Status

Coverage increased (+0.04%) to 57.79% when pulling 8d07b07 on goodsonr:config-abi-airmass into 37644b1 on pytroll:develop.

@djhoese djhoese self-assigned this Feb 19, 2018
@djhoese djhoese added the enhancement code enhancements, features, improvements label Feb 19, 2018
djhoese
djhoese reviewed Feb 19, 2018
View reviewed changes
satpy/etc/enhancements/generic.yaml Outdated
@@ -70,6 +70,16 @@ enhancements:
stretch: crude
min_stretch: [-25, -40, 243]
max_stretch: [0, 5, 208]
airmass_abi_default:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the _default here? People are starting to think it means something when really I was just using _default to mean "not specific to any sensor or other specific identifying feature". @mraspaud not sure if you have an opinion on this.

@goodsonr
Copy link
Contributor Author

I'm happy either way you two want it. I thought maybe you wanted the "default" here to say it is the default for abi. Want me to change it now or wait for @mraspaud to chime-in?

@djhoese
Copy link
Member

djhoese commented Feb 19, 2018

Let's wait. We should probably define a rule. Even if it is an undocumented one for now, @mraspaud and I should agree on something.

@djhoese
Copy link
Member

djhoese commented Feb 20, 2018

@goodsonr I just talked to Martin on slack. We think that the _default should be removed for anything that isn't generic. So any sensor specific enhancements should end in _<sensor> when possible. So your enhancement should be airmass_abi. In the future we might create separate yaml files per sensor. I think we allow that now, but it isn't heavily tested.

@djhoese djhoese merged commit 24986bf into pytroll:develop Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhoese djhoese djhoese left review comments

Assignees

@djhoese djhoese

Labels
component:compositors component:enhancements enhancement code enhancements, features, improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@goodsonr @coveralls @djhoese