Add support for CMIC product from PPSv2021 #1992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraspaud
added
enhancement
Codecov Report
@@ Coverage Diff @@
## main #1992 +/- ##
==========================================
+ Coverage 93.54% 93.64% +0.10%
==========================================
Files 279 282 +3
Lines 41322 41823 +501
==========================================
+ Hits 38654 39165 +511
+ Misses 2668 2658 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@ninahakansson feel free to have a look! |
djhoese
reviewed
Feb 18, 2022
djhoese
reviewed
Feb 18, 2022
| unzip.return_value = '' | ||
| self.scn = NcNWCSAF('filename', {}, {}) | ||
| self.filehandler_class = NcNWCSAF | ||
| self.scn = self.filehandler_class('filename', {}, {}) |
There was a problem hiding this comment.
Can this property be renamed to avoid confusion? I was already confused when you set self.scn.nc in one of the tests since that isn't something a Scene should have.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CPP product has been renamed in NWCSAF 2021 to CMIC, and even if the datasets inside are the same, the name of the variables in the nc files have been changed. This PR allows reading either file transparently by introducing file_keys and prefixes to the nwcsaf-nc reader.
Moreover, the default composites for these products have been updated.