Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update abi_l2_nc to include filename metadata similar to abi_l1b #2007

Merged
merged 2 commits into from Feb 5, 2022

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Feb 3, 2022

This PR makes the abi_l2_nc reader more consistent with the abi_l1b reader. My use case is that I want to format my output filenames (from Scene.save_datasets) similarly for all ABI data. Right now that includes some of the information about the sector and a few other parameters in the filename. Not all of this information was available, but has been added in this PR.

CC @yufeizhu600. If you could please review these changes it would be greatly appreciated.

  • Closes #xxxx
  • Tests added

@djhoese djhoese added enhancement code enhancements, features, improvements component:readers labels Feb 3, 2022
@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #2007 (c72bfbb) into main (c5c7c8c) will increase coverage by 0.00%.
The diff coverage is 94.11%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2007   +/-   ##
=======================================
  Coverage   93.55%   93.56%           
=======================================
  Files         281      281           
  Lines       41443    41488   +45     
=======================================
+ Hits        38774    38819   +45     
  Misses       2669     2669           
Flag Coverage Δ
behaviourtests 4.77% <0.00%> (-0.01%) ⬇️
unittests 94.09% <94.11%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/abi_l2_nc.py 96.00% <93.75%> (+0.76%) ⬆️
satpy/tests/reader_tests/test_abi_l2_nc.py 100.00% <100.00%> (ø)
satpy/tests/reader_tests/test_ahi_hrit.py 100.00% <0.00%> (ø)
satpy/tests/writer_tests/test_cf.py 99.69% <0.00%> (+<0.01%) ⬆️
satpy/readers/hrit_jma.py 97.98% <0.00%> (+0.04%) ⬆️
satpy/writers/cf_writer.py 94.35% <0.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5c7c8c...c72bfbb. Read the comment docs.

@coveralls
Copy link

coveralls commented Feb 3, 2022

Coverage Status

Coverage increased (+0.007%) to 94.027% when pulling c72bfbb on djhoese:feature-abi-l2-filename-metadata into c5c7c8c on pytroll:main.

@yufeizhu600
Copy link
Contributor

LGTM.

@djhoese djhoese merged commit e27414f into pytroll:main Feb 5, 2022
@djhoese djhoese deleted the feature-abi-l2-filename-metadata branch February 5, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants