-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix angle generation caching occassionally swapping results #2013
Conversation
Note in the stacked area definition test case I "moved" the area definitions over in the X dimension because them being centered on the reference longitude of the projection made them not fail my new reversed glob tests. |
Codecov Report
@@ Coverage Diff @@
## main #2013 +/- ##
=======================================
Coverage 93.55% 93.55%
=======================================
Files 282 282
Lines 41538 41548 +10
=======================================
+ Hits 38860 38870 +10
Misses 2678 2678
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! great 🕵️ work!
This PR fixes angle generation caching in the rare case that
glob
(which is defined as not being sorted) would return the list of zarr directories in the wrong order. My caching code assumed that it was getting the zarr files in the same order as the return results of the function being cached. And even though I know thatglob
behaves this way I somehow missed thesorted
on the call. 🤷♂️