Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the sensor name for msu_gsa_l1b reader #2016

Merged
merged 3 commits into from Apr 12, 2022

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Feb 9, 2022

The sensor property is used to find for example the enhancement configuration files for the data. The original platform name MSU-GS/A doesn't work for this, as there is the / character that denotes a sub-directory in *NIX world. This PR changes the sensor name to "Pytroll standards".

@pnuu pnuu added the bug label Feb 9, 2022
@pnuu pnuu self-assigned this Feb 9, 2022
@pnuu
Copy link
Member Author

pnuu commented Feb 9, 2022

Oh. Should the whitespace be removed from the platform_name property? The current one would cause filename patterns like {start_time:%Y%m%d_%H%M}_{platform_name}_{areaname}_{productname}.{format} have a space in them.

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #2016 (c41d378) into main (73ec5ad) will increase coverage by 0.30%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2016      +/-   ##
==========================================
+ Coverage   93.56%   93.87%   +0.30%     
==========================================
  Files         282      283       +1     
  Lines       41629    42380     +751     
==========================================
+ Hits        38952    39783     +831     
+ Misses       2677     2597      -80     
Flag Coverage Δ
behaviourtests 4.72% <0.00%> (-0.06%) ⬇️
unittests 94.43% <100.00%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/msu_gsa_l1b.py 100.00% <100.00%> (ø)
satpy/tests/reader_tests/test_msu_gsa_l1b.py 100.00% <100.00%> (ø)
satpy/_compat.py 66.66% <0.00%> (-8.34%) ⬇️
satpy/tests/writer_tests/test_ninjogeotiff.py 96.52% <0.00%> (-1.18%) ⬇️
satpy/modifiers/_crefl.py 93.02% <0.00%> (-1.17%) ⬇️
satpy/modifiers/_crefl_utils.py 92.04% <0.00%> (-1.14%) ⬇️
satpy/tests/reader_tests/test_ahi_hsd.py 99.60% <0.00%> (-0.40%) ⬇️
satpy/readers/seviri_l1b_hrit.py 90.14% <0.00%> (-0.32%) ⬇️
satpy/readers/scmi.py 82.69% <0.00%> (-0.22%) ⬇️
satpy/readers/electrol_hrit.py 91.40% <0.00%> (-0.20%) ⬇️
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73ec5ad...c41d378. Read the comment docs.

@coveralls
Copy link

coveralls commented Feb 9, 2022

Coverage Status

Coverage increased (+0.3%) to 94.372% when pulling c41d378 on pnuu:fix-msu_gsa-sensor-name into 73ec5ad on pytroll:main.

@pnuu
Copy link
Member Author

pnuu commented Feb 10, 2022

I also replaced the space in platform_name with a dash to get nicer filenames when saving images.

@simonrp84
Copy link
Member

simonrp84 commented Feb 10, 2022

Thanks for doing this @pnuu.
One thing, though - I set the platform name up like this because that's how it is for Electro-L:

SPACECRAFTS = {19001: "Electro-L N1",
               19002: "Electro-L N2",
               19003: "Electro-L N3"}

Should we also correct the names for that reader and, if so, maybe you could do it in this PR too?

@mraspaud
Copy link
Member

@pnuu looks like you broke a test...

@mraspaud
Copy link
Member

@pnuu ping :)

@pnuu
Copy link
Member Author

pnuu commented Apr 12, 2022

Dang. Fixing in a bit.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 6742882 into pytroll:main Apr 12, 2022
@pnuu pnuu deleted the fix-msu_gsa-sensor-name branch May 2, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants