New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the sensor name for msu_gsa_l1b reader #2016
Conversation
Oh. Should the whitespace be removed from the |
Codecov Report
@@ Coverage Diff @@
## main #2016 +/- ##
==========================================
+ Coverage 93.56% 93.87% +0.30%
==========================================
Files 282 283 +1
Lines 41629 42380 +751
==========================================
+ Hits 38952 39783 +831
+ Misses 2677 2597 -80
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I also replaced the space in |
Thanks for doing this @pnuu.
Should we also correct the names for that reader and, if so, maybe you could do it in this PR too? |
@pnuu looks like you broke a test... |
@pnuu ping :) |
Dang. Fixing in a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The
sensor
property is used to find for example the enhancement configuration files for the data. The original platform nameMSU-GS/A
doesn't work for this, as there is the/
character that denotes a sub-directory in *NIX world. This PR changes the sensor name to "Pytroll standards".