Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ABI rayleigh_corrected_crefl modifier using deprecated DEM specifier #2017

Merged
merged 1 commit into from Feb 9, 2022

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Feb 9, 2022

Forgot to fix this in #2015. The ABI crefl modifier wasn't updated when I changed how the CMGDEM.hdf files are downloaded/loaded by the modifier. It should point to a URL that can get downloaded and not a non-existent file.

  • Closes #xxxx
  • Tests added

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #2017 (870d287) into main (9e17b74) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2017      +/-   ##
==========================================
- Coverage   93.56%   93.56%   -0.01%     
==========================================
  Files         282      282              
  Lines       41637    41637              
==========================================
- Hits        38958    38957       -1     
- Misses       2679     2680       +1     
Flag Coverage Δ
behaviourtests 4.78% <ø> (ø)
unittests 94.09% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/modifiers/_crefl.py 93.02% <0.00%> (-1.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e17b74...870d287. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 94.021% when pulling 870d287 on djhoese:bugfix-abi-crefl-height into 9e17b74 on pytroll:main.

@djhoese djhoese merged commit 367d51d into pytroll:main Feb 9, 2022
@djhoese djhoese deleted the bugfix-abi-crefl-height branch February 9, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants