Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify documentation regarding attributes used in get_angles #2020

Merged
merged 5 commits into from Feb 15, 2022

Conversation

ghiggi
Copy link
Contributor

@ghiggi ghiggi commented Feb 14, 2022

Add to the doc the missing attributes required by get_angles().

Add to the doc the missing attributes required by get_angles().
satpy/modifiers/angles.py Outdated Show resolved Hide resolved
Co-authored-by: David Hoese <david.hoese@ssec.wisc.edu>
@djhoese
Copy link
Member

djhoese commented Feb 14, 2022

Thanks for fixing this. Before merging I'd like to look at the generated website (the build_website CI job will make a tarball I can't download). I'm just writing this here to remind myself.

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #2020 (ef57885) into main (367d51d) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2020   +/-   ##
=======================================
  Coverage   93.56%   93.56%           
=======================================
  Files         282      282           
  Lines       41637    41637           
=======================================
+ Hits        38957    38958    +1     
+ Misses       2680     2679    -1     
Flag Coverage Δ
behaviourtests 4.78% <ø> (ø)
unittests 94.09% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/modifiers/angles.py 96.68% <ø> (ø)
satpy/readers/ahi_hsd.py 97.64% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 367d51d...ef57885. Read the comment docs.

@coveralls
Copy link

coveralls commented Feb 14, 2022

Coverage Status

Coverage increased (+0.002%) to 94.024% when pulling ef57885 on ghiggi:patch-1 into 367d51d on pytroll:main.

Without this placement any references to this section must force a title
for the reference.
@djhoese djhoese changed the title Update get_angles documentation Clarify documentation regarding attributes used in get_angles Feb 15, 2022
@djhoese
Copy link
Member

djhoese commented Feb 15, 2022

Thanks!

@djhoese djhoese merged commit 82112a6 into pytroll:main Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants