Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various metadata bugs in 'awips_tiled' writer #2032

Merged
merged 8 commits into from Mar 2, 2022

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Feb 21, 2022

Closes ssec/polar2grid#417

Kathy (@kathys) has been doing some testing and it looks like there were a couple metadata related issues with the AWIPS tiles being produced by this writer. Most of these are from past refactors and incomplete tests not catching them.

  • Closes #xxxx
  • Tests added

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #2032 (21b4756) into main (5ed7871) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2032   +/-   ##
=======================================
  Coverage   93.65%   93.65%           
=======================================
  Files         282      282           
  Lines       41875    41865   -10     
=======================================
- Hits        39217    39209    -8     
+ Misses       2658     2656    -2     
Flag Coverage Δ
behaviourtests 4.76% <0.00%> (+<0.01%) ⬆️
unittests 94.18% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/tests/writer_tests/test_awips_tiled.py 99.04% <100.00%> (+0.57%) ⬆️
satpy/writers/awips_tiled.py 84.04% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ed7871...21b4756. Read the comment docs.

@djhoese
Copy link
Member Author

djhoese commented Feb 22, 2022

Just committed a blank commit to see if codefactor was happy after a bug fix on their side but as I pushed it I realized it was already passing. Oops.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 94.114% when pulling 21b4756 on djhoese:bugfix-awips-tiled into 5ed7871 on pytroll:main.

@djhoese
Copy link
Member Author

djhoese commented Mar 2, 2022

CC @joleenf

We have confirmation from Lee Cronce at SSEC that the files produced with these changes now load successfully and look as expected. I'll merge this in a little bit.

@djhoese djhoese self-assigned this Mar 2, 2022
@djhoese
Copy link
Member Author

djhoese commented Mar 2, 2022

Given the size of these changes and that I'm the only one of the core developers familiar with this writer, I'm just going to merge it. If it is decided that this should have had a review then let's define that somewhere.

@djhoese djhoese merged commit 4014846 into pytroll:main Mar 2, 2022
@djhoese djhoese deleted the bugfix-awips-tiled branch March 2, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

P2G V3.0 files cannot be displayed in AWIPS
2 participants