New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various metadata bugs in 'awips_tiled' writer #2032
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2032 +/- ##
=======================================
Coverage 93.65% 93.65%
=======================================
Files 282 282
Lines 41875 41865 -10
=======================================
- Hits 39217 39209 -8
+ Misses 2658 2656 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Just committed a blank commit to see if codefactor was happy after a bug fix on their side but as I pushed it I realized it was already passing. Oops. |
CC @joleenf We have confirmation from Lee Cronce at SSEC that the files produced with these changes now load successfully and look as expected. I'll merge this in a little bit. |
Given the size of these changes and that I'm the only one of the core developers familiar with this writer, I'm just going to merge it. If it is decided that this should have had a review then let's define that somewhere. |
Closes ssec/polar2grid#417
Kathy (@kathys) has been doing some testing and it looks like there were a couple metadata related issues with the AWIPS tiles being produced by this writer. Most of these are from past refactors and incomplete tests not catching them.