Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit handling in ERF DNB normalization's saturation correction #2044

Merged
merged 5 commits into from Mar 3, 2022

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Mar 3, 2022

@kathys noticed that when using the saturation correction option on the dynamic_dnb (ERFDNB) composite that the result was all black. This was a dumb logic bug by me when I ported the code to satpy from Polar2Grid and the tests not being very comprehensive. This PR fixes it. See related PR and issue discussion in Polar2Grid: ssec/polar2grid#424

  • Tests added
  • Fully documented

@djhoese djhoese requested a review from mraspaud as a code owner March 3, 2022 14:42
@djhoese djhoese changed the title Bugfix erf dnb satcorr Fix unit handling in ERF DNB normalization's saturation correction Mar 3, 2022
@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #2044 (1e1d549) into main (4014846) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2044      +/-   ##
==========================================
+ Coverage   93.66%   93.69%   +0.03%     
==========================================
  Files         282      282              
  Lines       41995    41990       -5     
==========================================
+ Hits        39336    39344       +8     
+ Misses       2659     2646      -13     
Flag Coverage Δ
behaviourtests 4.73% <0.00%> (+<0.01%) ⬆️
unittests 94.24% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/composites/viirs.py 89.86% <100.00%> (+3.46%) ⬆️
satpy/tests/compositor_tests/test_viirs.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4014846...1e1d549. Read the comment docs.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 94.179% when pulling 1e1d549 on djhoese:bugfix-erf-dnb-satcorr into 4014846 on pytroll:main.

@djhoese djhoese merged commit df832ed into pytroll:main Mar 3, 2022
@djhoese djhoese deleted the bugfix-erf-dnb-satcorr branch March 3, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants