Fix DifferenceCompositor not using metadata from YAML #2054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhoese
commented
Mar 11, 2022
| comp = DifferenceCompositor(name='diff') | ||
| res = comp((self.ds1, self.ds2), standard_name='temperature_difference') | ||
| comp = DifferenceCompositor(name='diff', standard_name='temperature_difference') | ||
| res = comp((self.ds1, self.ds2)) |
There was a problem hiding this comment.
This test was incorrect. Passing standard_name to the __call__ method of a compositor will never happen. Only the Scene calls __call__ and it passed the DataID properties computed during dependency decisions. The __init__ method is when metadata from the YAML are passed.
Codecov Report
@@ Coverage Diff @@
## main #2054 +/- ##
=======================================
Coverage 93.79% 93.79%
=======================================
Files 282 282
Lines 42170 42171 +1
=======================================
+ Hits 39554 39555 +1
Misses 2616 2616
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found out the
standard_name:I was assigning in the YAML wasn't being assigned.