Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SLSTR calibration coefficients #2056

Merged
merged 1 commit into from Mar 16, 2022
Merged

Conversation

simonrp84
Copy link
Member

@simonrp84 simonrp84 commented Mar 11, 2022

The SLSTR calibration coefficients supplied in the reader are old and incorrect, this PR updates the coefficients to the latest ones supplied by EUM/ESA/Copernicus.

  • Tests passed

@djhoese
Copy link
Member

djhoese commented Mar 11, 2022

Just because I know people...should we make it possible to switch between them? I think you did this for other readers, right?

@djhoese djhoese added enhancement code enhancements, features, improvements component:readers labels Mar 11, 2022
@simonrp84
Copy link
Member Author

No, it should not be possible to switch between the old and new ones: The old ones were incorrect.

Also, the option already exists in the code (via user_calib kwarg) for the user to supply their own calibration values.

@djhoese
Copy link
Member

djhoese commented Mar 11, 2022

Ah your description says "outdated" so I assumed they were corrected/updated, but not necessarily invalid before. Were these like pre-launch coefficients or something?

@simonrp84
Copy link
Member Author

Heh, true. Have updated the description. Long story regarding why these values are needed: but the old values were from a previous iteration of the calibration efforts. New values are much more robust as they're derived from a) A longer time series and b) More validation sites.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #2056 (29d28ed) into main (01902ba) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2056   +/-   ##
=======================================
  Coverage   93.79%   93.79%           
=======================================
  Files         282      282           
  Lines       42171    42171           
=======================================
  Hits        39555    39555           
  Misses       2616     2616           
Flag Coverage Δ
behaviourtests 4.74% <0.00%> (ø)
unittests 94.33% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/slstr_l1b.py 97.29% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01902ba...29d28ed. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.275% when pulling 29d28ed on simonrp84:update_slstr into 01902ba on pytroll:main.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 8fc820b into pytroll:main Mar 16, 2022
@simonrp84 simonrp84 deleted the update_slstr branch April 23, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants