New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SLSTR calibration coefficients #2056
Conversation
Just because I know people...should we make it possible to switch between them? I think you did this for other readers, right? |
No, it should not be possible to switch between the old and new ones: The old ones were incorrect. Also, the option already exists in the code (via |
Ah your description says "outdated" so I assumed they were corrected/updated, but not necessarily invalid before. Were these like pre-launch coefficients or something? |
Heh, true. Have updated the description. Long story regarding why these values are needed: but the old values were from a previous iteration of the calibration efforts. New values are much more robust as they're derived from a) A longer time series and b) More validation sites. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #2056 +/- ##
=======================================
Coverage 93.79% 93.79%
=======================================
Files 282 282
Lines 42171 42171
=======================================
Hits 39555 39555
Misses 2616 2616
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The SLSTR calibration coefficients supplied in the reader are old and incorrect, this PR updates the coefficients to the latest ones supplied by EUM/ESA/Copernicus.