Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filename to YAML for NASA NRT VIIRS files with creation date/time. #2065

Merged
merged 1 commit into from Apr 8, 2022

Conversation

simonrp84
Copy link
Member

The viirs_l1b format currently doesn't support files from the NASA / earthdata NRT data feed as these files contain the creation date in the filename.
This PR adds support for the NRT files by updating the YAML appropriately.

@simonrp84 simonrp84 requested a review from djhoese as a code owner March 17, 2022 20:25
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another filenaming scheme from the same vendor? Ok.

@simonrp84
Copy link
Member Author

I have no idea if the existing NRT file format in the YAML is still applicable (the one without the creation date) but all the VIIRS L1b NRT files I've seen recently do contain the date. Will keep an eye on it, maybe we can delete the old one in the future.

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #2065 (60bc02e) into main (e9caa3d) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2065      +/-   ##
==========================================
- Coverage   93.80%   93.78%   -0.02%     
==========================================
  Files         282      282              
  Lines       42204    42250      +46     
==========================================
+ Hits        39590    39626      +36     
- Misses       2614     2624      +10     
Flag Coverage Δ
behaviourtests 4.74% <ø> (+<0.01%) ⬆️
unittests 94.35% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/utils.py 26.71% <0.00%> (-0.20%) ⬇️
satpy/tests/test_utils.py 100.00% <0.00%> (ø)
satpy/readers/hrpt.py 98.64% <0.00%> (+0.02%) ⬆️
satpy/readers/aapp_l1b.py 89.73% <0.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9caa3d...60bc02e. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.291% when pulling 60bc02e on simonrp84:viirs_nrt into f34d563 on pytroll:main.

@mraspaud mraspaud merged commit a6f5cdf into pytroll:main Apr 8, 2022
@mraspaud mraspaud added enhancement code enhancements, features, improvements component:readers labels Apr 8, 2022
@simonrp84 simonrp84 deleted the viirs_nrt branch April 8, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants