New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FCI reader for new test data release and add patches for IDPF data #2086
Update FCI reader for new test data release and add patches for IDPF data #2086
Conversation
…a chunk with an offset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one small note
Codecov Report
@@ Coverage Diff @@
## main #2086 +/- ##
==========================================
+ Coverage 93.85% 93.89% +0.04%
==========================================
Files 283 283
Lines 42417 42537 +120
==========================================
+ Hits 39811 39942 +131
+ Misses 2606 2595 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This PR adds minor modifications to the FCI reader:
the index map retrieval mechanism is updated to use the index variable, to account for format changes in the upcoming test data release. The reader still works also with older test data.
two patches (wrong geolocation paramters and earth_sun_distance data) are added to make the reader work also for IDPF data (as released e.g. to SAFs) as discussed on Slack.
a note is added to the FCI example and docstring to note that hdf5plugin can be used for automatic decompression (while we fix the issues in Use hdf5plugin for FCI decompression #2043
Tests added
Fully documented