Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FCI reader for new test data release and add patches for IDPF data #2086

Merged

Conversation

ameraner
Copy link
Member

@ameraner ameraner commented Apr 13, 2022

This PR adds minor modifications to the FCI reader:

  • the index map retrieval mechanism is updated to use the index variable, to account for format changes in the upcoming test data release. The reader still works also with older test data.

  • two patches (wrong geolocation paramters and earth_sun_distance data) are added to make the reader work also for IDPF data (as released e.g. to SAFs) as discussed on Slack.

  • a note is added to the FCI example and docstring to note that hdf5plugin can be used for automatic decompression (while we fix the issues in Use hdf5plugin for FCI decompression #2043

  • Tests added

  • Fully documented

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small note

satpy/readers/fci_l1c_nc.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #2086 (bef97cc) into main (7386c43) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2086      +/-   ##
==========================================
+ Coverage   93.85%   93.89%   +0.04%     
==========================================
  Files         283      283              
  Lines       42417    42537     +120     
==========================================
+ Hits        39811    39942     +131     
+ Misses       2606     2595      -11     
Flag Coverage Δ
behaviourtests 4.71% <0.00%> (-0.01%) ⬇️
unittests 94.45% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/fci_l1c_nc.py 98.02% <100.00%> (+0.09%) ⬆️
satpy/tests/reader_tests/test_fci_l1c_nc.py 100.00% <100.00%> (ø)
satpy/modifiers/_crefl.py 92.40% <0.00%> (-0.62%) ⬇️
satpy/tests/test_crefl_utils.py 100.00% <0.00%> (ø)
satpy/tests/modifier_tests/test_crefl.py 100.00% <0.00%> (+0.51%) ⬆️
satpy/tests/test_config.py 94.61% <0.00%> (+0.76%) ⬆️
satpy/tests/reader_tests/test_vii_base_nc.py 100.00% <0.00%> (+1.24%) ⬆️
satpy/tests/reader_tests/test_nwcsaf_msg.py 100.00% <0.00%> (+1.80%) ⬆️
satpy/tests/reader_tests/test_vii_l1b_nc.py 100.00% <0.00%> (+2.81%) ⬆️
satpy/modifiers/_crefl_utils.py 95.09% <0.00%> (+3.04%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7386c43...bef97cc. Read the comment docs.

@ameraner ameraner self-assigned this Apr 13, 2022
@ameraner ameraner added enhancement code enhancements, features, improvements component:readers pre-launch For instruments not yet launched labels Apr 13, 2022
@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 94.398% when pulling bef97cc on ameraner:feature_update_fci_reader_for_datacube_td into 67b11b2 on pytroll:main.

@mraspaud mraspaud merged commit dd77305 into pytroll:main Apr 13, 2022
@ameraner ameraner deleted the feature_update_fci_reader_for_datacube_td branch May 17, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements pre-launch For instruments not yet launched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants