Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor HRIT/LRIT format reader. #2087

Merged
merged 1 commit into from Apr 14, 2022
Merged

Refactor HRIT/LRIT format reader. #2087

merged 1 commit into from Apr 14, 2022

Conversation

sbrodehl
Copy link
Contributor

Refactor HRIT/LRIT format reader code, as mentioned in #2076 .

  • Add your name to AUTHORS.md if not there already

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #2087 (c1d469b) into main (dd77305) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2087   +/-   ##
=======================================
  Coverage   93.89%   93.90%           
=======================================
  Files         283      283           
  Lines       42537    42543    +6     
=======================================
+ Hits        39942    39948    +6     
  Misses       2595     2595           
Flag Coverage Δ
behaviourtests 4.71% <0.00%> (-0.01%) ⬇️
unittests 94.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/hrit_base.py 83.06% <100.00%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd77305...c1d469b. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0008%) to 94.399% when pulling c1d469b on sbrodehl:dev-hrit-base-refactor into dd77305 on pytroll:main.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking the time, it's much cleaner indeed!

Copy link
Member

@sfinkens sfinkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot for taking the time!

@mraspaud mraspaud merged commit 7b6c231 into pytroll:main Apr 14, 2022
@sbrodehl sbrodehl deleted the dev-hrit-base-refactor branch April 15, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants