Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #2097

Merged
merged 2 commits into from May 3, 2022
Merged

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented May 2, 2022

updates:
- [github.com/pre-commit/mirrors-mypy: v0.942 → v0.950](pre-commit/mirrors-mypy@v0.942...v0.950)
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #2097 (7b943d5) into main (20434bf) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2097   +/-   ##
=======================================
  Coverage   93.89%   93.89%           
=======================================
  Files         283      283           
  Lines       42589    42589           
=======================================
  Hits        39991    39991           
  Misses       2598     2598           
Flag Coverage Δ
behaviourtests 4.70% <100.00%> (ø)
unittests 94.45% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/dataset/dataid.py 95.22% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20434bf...7b943d5. Read the comment docs.

@mraspaud
Copy link
Member

mraspaud commented May 2, 2022

@djhoese looks like mypy is failing?

@djhoese
Copy link
Member

djhoese commented May 2, 2022

I thought we skipped mypy on CI? Oh or did I "fix" that? Shoot. I'm about to make a PR so I'll see what I can do in my PR.

@coveralls
Copy link

coveralls commented May 2, 2022

Coverage Status

Coverage remained the same at 94.398% when pulling 7b943d5 on pre-commit-ci-update-config into 20434bf on main.

@djhoese
Copy link
Member

djhoese commented May 2, 2022

@mraspaud This is ready for review and merge. Basically it looks like the type definition for the stdlib dict has been updated to make one of the methods (setdefault) with multiple override type definitions. I had already ignored similar methods so this was just another ignore for a very similar method definition.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 137f752 into main May 3, 2022
@mraspaud mraspaud deleted the pre-commit-ci-update-config branch May 3, 2022 06:17
@mraspaud mraspaud added the enhancement code enhancements, features, improvements label May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants