Bugfix check if lons and lats should be masked before resampling #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhoese
reviewed
Mar 7, 2018
| @@ -673,7 +673,7 @@ def mask_source_lonlats(source_def, mask): | |||
| # the data may have additional masked pixels | |||
| # let's compare them to see if we can use the same area | |||
| # assume lons and lats mask are the same | |||
| if mask and isinstance(source_geo_def, SwathDefinition): | |||
| if mask is not None and mask is not False and isinstance(source_geo_def, SwathDefinition): | |||
There was a problem hiding this comment.
Isn't mask at this point either None or an array?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix check if lons and lats should be masked before resampling, because it was buggy.
git diff origin/develop **/*py | flake8 --diff