New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more products to fci_l2_nc reader #2102
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2102 +/- ##
==========================================
- Coverage 93.92% 93.92% -0.01%
==========================================
Files 283 283
Lines 42715 42714 -1
==========================================
- Hits 40120 40119 -1
Misses 2595 2595
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…g dataset to CommonFunctions class since CRM needs this functionality too.
Coverage tests are most likely failing because some lines of tested code have been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR adds some more products to the
fci_l2_nc
reader. It also makes thefile_patterns
in the yaml-file less stringent in order to be compatible with L2 files from different processing environments.The PR is mostly about adding new product entries entries in the
yaml
-file, but also include some minor changes in thepy
-file in order to allow both the CRM and OCA products to use the_slice_dataset
method, initially developed for the multi-dimensional segmented ASR product.file_patterns
less stringent.