Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more products to fci_l2_nc reader #2102

Merged
merged 3 commits into from May 6, 2022

Conversation

strandgren
Copy link
Collaborator

@strandgren strandgren commented May 5, 2022

This PR adds some more products to the fci_l2_nc reader. It also makes the file_patterns in the yaml-file less stringent in order to be compatible with L2 files from different processing environments.

The PR is mostly about adding new product entries entries in the yaml-file, but also include some minor changes in the py-file in order to allow both the CRM and OCA products to use the _slice_dataset method, initially developed for the multi-dimensional segmented ASR product.

  • Make file_patterns less stringent.
  • Add FIR product
  • Add OLR product
  • Add CRM product

@pnuu pnuu added this to In progress in PCW Spring 2022 via automation May 5, 2022
@pnuu pnuu added enhancement code enhancements, features, improvements component:readers labels May 5, 2022
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #2102 (fddcaad) into main (56eb21b) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2102      +/-   ##
==========================================
- Coverage   93.92%   93.92%   -0.01%     
==========================================
  Files         283      283              
  Lines       42715    42714       -1     
==========================================
- Hits        40120    40119       -1     
  Misses       2595     2595              
Flag Coverage Δ
behaviourtests 4.71% <0.00%> (+<0.01%) ⬆️
unittests 94.48% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/fci_l2_nc.py 99.45% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56eb21b...fddcaad. Read the comment docs.

@coveralls
Copy link

coveralls commented May 5, 2022

Coverage Status

Coverage decreased (-0.0001%) to 94.421% when pulling fddcaad on strandgren:add_more_fci_l2_products into 56eb21b on pytroll:main.

@strandgren strandgren marked this pull request as ready for review May 5, 2022 15:07
@strandgren
Copy link
Collaborator Author

Coverage tests are most likely failing because some lines of tested code have been removed.

@pnuu pnuu moved this from In progress to Ready for review in PCW Spring 2022 May 5, 2022
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mraspaud mraspaud merged commit 4971b7c into pytroll:main May 6, 2022
PCW Spring 2022 automation moved this from Ready for review to Done May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants