Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functions to automatically generate reader table for documentation #2108
Functions to automatically generate reader table for documentation #2108
Changes from 3 commits
cee083f
b05c248
e648569
84d3253
9f98f75
44b5593
2834049
cc64616
d080118
76f67a1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be clear about what options should be used here? Maybe limit it to a set of 3 or 4?
Not sure we need something more than those. Other ideas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add Alpha. But in the old table there sometimes are comments for status other than the suggested three (for example the
seviri_l1b_nc
reader says that HRV is currently not supported. I don't know if such comments should be in a different column or should be allowed in the status column?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...yeah that's difficult to say what is best. It makes the most sense in status, but it also seems ugly and prevents that column from staying small.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@djhoese so I kept the comments in the status column for now since only a few of the readers had status comments and it felt overkill to have a extra column which is mostly empty. It looks like this now:
I added questionmarks for readers for which the status was unclear for me (see my comment below)