Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yaml files for some seviri/abi/ahi BlackMarble background composites #2122

Merged
merged 1 commit into from Jul 29, 2022

Conversation

lobsiger
Copy link
Contributor

@lobsiger lobsiger commented Jun 9, 2022

Some changes to satpy/etc/composites/*.yaml for composites using the NASA BlackMarble as night background.

For a full discussion of problems solved or remaining see: https://groups.google.com/g/pytroll/c/qjg5zddABA0

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #2122 (f54d6d3) into main (8b5d493) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2122   +/-   ##
=======================================
  Coverage   93.88%   93.88%           
=======================================
  Files         283      283           
  Lines       43093    43093           
=======================================
  Hits        40458    40458           
  Misses       2635     2635           
Flag Coverage Δ
behaviourtests 4.78% <ø> (ø)
unittests 94.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b5d493...f54d6d3. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.48% when pulling f54d6d3 on lobsiger:blackmarble into 8b5d493 on pytroll:main.

@gerritholl
Copy link
Collaborator

Is this ready to be merged?

@djhoese
Copy link
Member

djhoese commented Jul 29, 2022

The failing test is an HTTP download hiccup in the unstable environment. I'm not worried about it. This looks good to me and is much needed. Merging...

@djhoese djhoese merged commit a864aae into pytroll:main Jul 29, 2022
@lobsiger lobsiger deleted the blackmarble branch February 15, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants