Reuse same resampler for similar datasets #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
djhoese
reviewed
Mar 9, 2018
satpy/readers/aapp_l1b.py
Outdated
| @@ -54,7 +55,7 @@ | |||
|
|
|||
|
|
|||
| def create_xarray(arr): | |||
| res = da.from_array(arr, chunks=(1000, 1000)) | |||
| res = da.from_array(arr, chunks=(CHUNK_SIZE, CHUNK_SIZE)) | |||
| res = xr.DataArray(res, dims=['y', 'x'], | |||
| coords=[np.arange(res.shape[0]), | |||
| np.arange(res.shape[1])]) | |||
There was a problem hiding this comment.
Doesn't xarray create these coordinates on the fly if needed?
There was a problem hiding this comment.
The coordinates could be da.arange though, right? Plus since these are just aranges I don't think anything would use them. If you did operations with a non-coords array that had y/x dimensions and one that did I think it fills in the blanks.
djhoese
approved these changes
Mar 13, 2018
mraspaud
added
enhancement
djhoese
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide better mechanism for using the same resampler over multiple datasets
git diff origin/develop **/*py | flake8 --diff