Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the CRR-Ph files to the nwcsaf geo yaml file #2147

Merged
merged 2 commits into from Jul 22, 2022
Merged

Conversation

uhamann
Copy link
Contributor

@uhamann uhamann commented Jul 22, 2022

added the CRR-Ph files (including the data products description) to the nwcsaf-geo.yaml file,
as it was missing

CRR-Ph files can be found with find_files_and_readers
datasets can be loaded

Cheers,
Ulrich

including the dataset descriptions
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking the time for complementing the convection products!

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #2147 (0dc10ff) into main (fa93ac9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2147   +/-   ##
=======================================
  Coverage   93.88%   93.88%           
=======================================
  Files         283      283           
  Lines       43123    43123           
=======================================
  Hits        40488    40488           
  Misses       2635     2635           
Flag Coverage Δ
behaviourtests 4.78% <ø> (ø)
unittests 94.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.484% when pulling 0dc10ff on uhamann:main into fa93ac9 on pytroll:main.

@mraspaud mraspaud merged commit ab3abfb into pytroll:main Jul 22, 2022
@mraspaud mraspaud added component:readers enhancement code enhancements, features, improvements labels Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants