Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default type of AWIPS tiled writer to int16 + _Unsigned #2151

Merged
merged 2 commits into from Jul 29, 2022

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Jul 28, 2022

Apparently AWIPS can't handle signed 16-bit integers.

  • Closes #xxxx
  • Tests added
  • Fully documented

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #2151 (42e4cd3) into main (ada50bb) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2151      +/-   ##
==========================================
+ Coverage   93.91%   93.95%   +0.03%     
==========================================
  Files         283      285       +2     
  Lines       43258    43755     +497     
==========================================
+ Hits        40626    41109     +483     
- Misses       2632     2646      +14     
Flag Coverage Δ
behaviourtests 4.73% <0.00%> (-0.05%) ⬇️
unittests 94.62% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/tests/writer_tests/test_awips_tiled.py 99.05% <100.00%> (+<0.01%) ⬆️
satpy/writers/awips_tiled.py 84.08% <100.00%> (+0.03%) ⬆️
satpy/utils.py 25.00% <0.00%> (-0.40%) ⬇️
satpy/tests/test_utils.py 100.00% <0.00%> (ø)
satpy/readers/gpm_imerg.py 100.00% <0.00%> (ø)
satpy/tests/modifier_tests/test_parallax.py 99.71% <0.00%> (ø)
satpy/modifiers/parallax.py 99.15% <0.00%> (ø)
satpy/composites/__init__.py 90.27% <0.00%> (+0.13%) ⬆️
satpy/tests/utils.py 94.38% <0.00%> (+0.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0006%) to 94.571% when pulling 42e4cd3 on djhoese:bugfix-awips-tiled-physelem into 8e039d6 on pytroll:main.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for cleaning up old comments.

@mraspaud mraspaud merged commit 4235d35 into pytroll:main Jul 29, 2022
@djhoese djhoese deleted the bugfix-awips-tiled-physelem branch August 1, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants