Document alternative for deprecated get_min/max_area #2153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the docstring for get_min_area and get_max_area, do not only write that they are deprecated, but also write what should be used instead.
djhoese
approved these changes
Jul 29, 2022
Codecov Report
@@ Coverage Diff @@
## main #2153 +/- ##
==========================================
- Coverage 93.95% 93.95% -0.01%
==========================================
Files 285 285
Lines 43755 43754 -1
==========================================
- Hits 41109 41108 -1
Misses 2646 2646
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
djhoese
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the docstrings for get_min_area and get_max_area, do not only write
that they are deprecated, but also write what should be used instead.