Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3d effect enhancement #2174

Merged
merged 1 commit into from Aug 15, 2022
Merged

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Aug 12, 2022

This PR fixes the 3d effect enhancement that was wrongly converted in dc28b1d to use map_block where it should be delayed.

Also, the enhancement tests are now running on dask array-based DataArray for more realism.

Also, run enhancement tests on dask array-based DataArray for more realism
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #2174 (be9b6ce) into main (dbe2838) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2174   +/-   ##
=======================================
  Coverage   93.99%   93.99%           
=======================================
  Files         287      287           
  Lines       44092    44092           
=======================================
  Hits        41446    41446           
  Misses       2646     2646           
Flag Coverage Δ
behaviourtests 4.78% <25.00%> (ø)
unittests 94.66% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/enhancements/__init__.py 99.15% <100.00%> (ø)
satpy/tests/enhancement_tests/test_enhancements.py 99.63% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.612% when pulling be9b6ce on mraspaud:fix-3d-enhancement into dbe2838 on pytroll:main.

@mraspaud
Copy link
Member Author

Confirmed by @lobsiger to fix the bug in #2173

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick fix. Feel free to merge.

@mraspaud mraspaud merged commit 768524f into pytroll:main Aug 15, 2022
@mraspaud mraspaud deleted the fix-3d-enhancement branch August 15, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MetopC script fails after update to SatPy 0.37
3 participants