Fix plugins not working with new versions of setuptools #2177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraspaud
requested changes
Aug 15, 2022
Codecov Report
@@ Coverage Diff @@
## main #2177 +/- ##
==========================================
- Coverage 94.03% 94.03% -0.01%
==========================================
Files 289 289
Lines 44541 44564 +23
==========================================
+ Hits 41884 41904 +20
- Misses 2657 2660 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mraspaud
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See pypa/setuptools#3527 for details. Bottom line is that
pkg_resourcesis kind of deprecated and Satpy was using undocumented function like the.dist.module_pathproperty. This PR updates Satpy to use importlib which has the necessary functionality as of Python 3.8 and is the minimum version of Python that Satpy supports. This also should fix the CI issues in pytroll/satpy-composites-plugin-example#2.