New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning for SEVIRI native reader in case of bad data #2198
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2198 +/- ##
==========================================
+ Coverage 94.01% 94.07% +0.05%
==========================================
Files 289 290 +1
Lines 44614 44667 +53
==========================================
+ Hits 41945 42021 +76
+ Misses 2669 2646 -23
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for adding this. Just a couple of things.
Both your comments should be addressed now @mraspaud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
On occasion, a SEVIRI native file contains bad data in which the digital counts in the file are invalid. This is not picked up by the reader as there's no quality checking.
This PR adds a check for the QQOV flag in the header. In cases where it is NOK a warning is raised to alert the user that the file is likely to contain bad quality data.