Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of fallback to GDAL in geotiff writer #2200

Merged
merged 1 commit into from Sep 6, 2022

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Sep 6, 2022

This bad information came up in the monthly meeting we had today. The geotiff writer does not use GDAL's python bindings directly at all anymore. This PR removes the mention of this and states that rasterio is required.

  • Closes #xxxx
  • Tests added
  • Fully documented

@djhoese djhoese self-assigned this Sep 6, 2022
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #2200 (913d27a) into main (464d845) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2200   +/-   ##
=======================================
  Coverage   94.07%   94.07%           
=======================================
  Files         290      290           
  Lines       44667    44667           
=======================================
  Hits        42021    42021           
  Misses       2646     2646           
Flag Coverage Δ
behaviourtests 4.72% <ø> (ø)
unittests 94.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/writers/geotiff.py 93.75% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.682% when pulling 913d27a on doc-geotiff-gdalfallback into 464d845 on main.

@djhoese
Copy link
Member Author

djhoese commented Sep 6, 2022

Got approval on slack.

@djhoese djhoese merged commit 0ac492b into main Sep 6, 2022
@djhoese djhoese deleted the doc-geotiff-gdalfallback branch September 6, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants