Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update seadas_l2 reader to handle alternative NetCDF file format #2209

Merged
merged 2 commits into from Oct 6, 2022

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Sep 28, 2022

The SEADAS software being used by @kathys and Liam Gumley can produce HDF4 files (already supported) or NetCDF files. This PR adds support for the new files which have similar but slightly different structures.

Related Polar2Grid issue: ssec/polar2grid#457

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #2209 (fc652d7) into main (4baae95) will increase coverage by 0.00%.
The diff coverage is 98.05%.

@@           Coverage Diff           @@
##             main    #2209   +/-   ##
=======================================
  Coverage   94.14%   94.14%           
=======================================
  Files         294      294           
  Lines       45103    45178   +75     
=======================================
+ Hits        42461    42534   +73     
- Misses       2642     2644    +2     
Flag Coverage Δ
behaviourtests 4.67% <0.00%> (-0.01%) ⬇️
unittests 94.79% <98.05%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/seadas_l2.py 96.84% <96.66%> (-1.28%) ⬇️
satpy/tests/reader_tests/test_seadas_l2.py 99.07% <100.00%> (+0.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 94.747% when pulling fc652d7 on djhoese:feature-seadas-nc into 4baae95 on pytroll:main.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, just a question regarding style

satpy/tests/reader_tests/test_seadas_l2.py Show resolved Hide resolved
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 6d24db1 into pytroll:main Oct 6, 2022
@djhoese djhoese deleted the feature-seadas-nc branch October 6, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants